Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gopherbot: add the author of the change to the notification on github #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −4
Open

cmd/gopherbot: add the author of the change to the notification on github #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
590a834
cmd/gopherbot, maintner: add the author of the change to the notifica…
Jun 12, 2019
ebf4772
maintner: removed the cl url generator
Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cmd/gopherbot/gopherbot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,7 @@ func (b *gopherbot) closeStaleWaitingForInfo(ctx context.Context) error {

}

// cl2issue writes "Change https://golang.org/cl/NNNN mentions this issue"
// cl2issue writes "Change https://golang.org/cl/NNNN by AUTHOR mentions this issue"
// and the change summary on GitHub when a new Gerrit change references a GitHub issue.
func (b *gopherbot) cl2issue(ctx context.Context) error {
monthAgo := time.Now().Add(-30 * 24 * time.Hour)
Expand All @@ -915,6 +915,7 @@ func (b *gopherbot) cl2issue(ctx context.Context) error {
// already processed this issue.
return nil
}
prefix := fmt.Sprintf("Change https://golang.org/cl/%d", cl.Number)
for _, ref := range cl.GitHubIssueRefs {
if id := ref.Repo.ID(); id.Owner != "golang" || id.Repo != "go" {
continue
Expand All @@ -924,17 +925,17 @@ func (b *gopherbot) cl2issue(ctx context.Context) error {
continue
}
hasComment := false
substr := fmt.Sprintf("%d mentions this issue", cl.Number)
gi.ForeachComment(func(c *maintner.GitHubComment) error {
if strings.Contains(c.Body, substr) {
if strings.HasPrefix(c.Body, prefix) {
hasComment = true
return errStopIteration
}
return nil
})
if !hasComment {
printIssue("cl2issue", gi)
msg := fmt.Sprintf("Change https://golang.org/cl/%d mentions this issue: `%s`", cl.Number, cl.Commit.Summary())
author := cl.Owner().Name()
msg := fmt.Sprintf("%s by %s mentions this issue: `%s`", prefix, author, cl.Commit.Summary())
if err := b.addGitHubComment(ctx, "golang", "go", gi.Number, msg); err != nil {
return err
}
Expand Down