Expose more ReviewInfo fields in the Go Gerrit client

[alml]

No description provided.

[gopherbot]

This PR (HEAD: f9a86dd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/234660 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Andrew Bonventre:

Patch Set 1:

Hi Alex,
Can you give some reasoning for the justification of this change? Doesn’t have to be in the commit message, per se, but it would be helpful to know as we generally maintain this package for our own clients and don’t seek to support those outside of the Go team.

Thanks

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alex Lurye:

Patch Set 1:

Patch Set 1:

Hi Alex,
Can you give some reasoning for the justification of this change? Doesn’t have to be in the commit message, per se, but it would be helpful to know as we generally maintain this package for our own clients and don’t seek to support those outside of the Go team.

Thanks

Absolutely. I was working on a personal project (built an integration layer between a CI system and Gerrit) and found that the Go client library lacked a few important fields (notification settings - I didn't want to spam reviewers with build failures, only the CL author, and adding "autogenerated:" tag to the comments posted by CI). In the future I'll also need per-line robot comments.

While I only needed a few fields myself, I implemented all of them. If you don't like this CL, I can keep it in a fork of course, but I think it will benefit other users as well.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Andrew Bonventre:

Patch Set 1:

(2 comments)

Patch Set 1:

Patch Set 1:

Hi Alex,
Can you give some reasoning for the justification of this change? Doesn’t have to be in the commit message, per se, but it would be helpful to know as we generally maintain this package for our own clients and don’t seek to support those outside of the Go team.

Thanks

Absolutely. I was working on a personal project (built an integration layer between a CI system and Gerrit) and found that the Go client library lacked a few important fields (notification settings - I didn't want to spam reviewers with build failures, only the CL author, and adding "autogenerated:" tag to the comments posted by CI). In the future I'll also need per-line robot comments.

While I only needed a few fields myself, I implemented all of them. If you don't like this CL, I can keep it in a fork of course, but I think it will benefit other users as well.

Got it. Thanks for the context. I think these are useful to have. A few minor comments but looks good.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Andrew Bonventre:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Dmitri Shuralyov:

Patch Set 1:

I'm not sure if you're already aware of it or not, so I want to point out there exists another general purpose Gerrit API client at https://pkg.go.dev/github.com/andygrunwald/go-gerrit. Its scope is to support the entire Gerrit API. It happens to already have many of the fields being added here.

It might be better if we document the scope of x/build/gerrit to be a subset of the Gerrit API needed by other packages in x/build, and re-direct other general purpose improvements to go-gerrit.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Wade Carpenter:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Wade Carpenter:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from TurkDevOps DevTurks-Team:

Patch Set 1: Code-Review+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Kadir Selçuk :

Patch Set 1: Code-Review+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Kadir Selçuk :

Patch Set 1: Code-Review+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/234660.
After addressing review feedback, remember to publish your drafts!