-
Notifications
You must be signed in to change notification settings - Fork 17.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: remove linkname from memhash{32,64} functions #67784
base: master
Are you sure you want to change the base?
Conversation
This commit is a cosmetic change. github.com/segmentio/parquet-go has been archived and moved to github.com/parquet-go/parquet-go and is not maintained by segment anymore. This commit removes references to the archived repository but keeps references to the equivalent and current github.com/parquet-go/parquet-go.
github.com/parquet-go/parquet-go was listed as the only user of these functions. parquet-go/parquet-go#142 removes the linkname dependency on these functions, so the linkname directive can now be removed.
This PR (HEAD: e14c4e4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/589795. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/589795. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/589795. |
Message from Alfonso Subiotto Marqués: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/589795. |
Message from Alfonso Subiotto Marqués: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/589795. |
Remove linkname directives that are no longer necessary given
parquet-go/parquet-go#142 removes the dependency on the
memhash{32,64}
functions.
This change also removes references to segmentio/parquet-go since that
repository was archived in favor of parquet-go/parquet-go.
Updates #67401