-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
context: add default to select example in comment of Done #70870
base: master
Are you sure you want to change the base?
context: add default to select example in comment of Done #70870
Conversation
This PR (HEAD: 1d3606e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/636755. Important tips:
|
According to the comment of Stream, it should return once ctx.Done is closed, but the current implementation may select another case instead if out is ready to receive an element. Quoting from the related Go spec: "If one or more of the communications can proceed, a single one that can proceed is chosen via a uniform pseudo-random selection." https://go.dev/ref/spec#Select_statements
1d3606e
to
6f2f1e4
Compare
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/636755. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/636755. |
This PR (HEAD: 6f2f1e4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/636755. Important tips:
|
Message from Hsing-Yu Chen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/636755. |
Message from Damien Neil: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/636755. |
Message from Hsing-Yu Chen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/636755. |
According to the comment of Stream, it should return once ctx.Done is
closed, but the current implementation may select another case instead
if out is ready to receive an element.
Quoting from the related Go spec: "If one or more of the
communications can proceed, a single one that can proceed is chosen
via a uniform pseudo-random selection."
https://go.dev/ref/spec#Select_statements