-
Notifications
You must be signed in to change notification settings - Fork 18.4k
crypto/rand: add syscall number fallbacks in seccomp_linux #75658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
cc @FiloSottile |
seccomp_linux.go is only used for Go's own tests (commit 6446285), but the package is included when building programs with CGO_ENABLED=1. When using an older glibc (e.g. 2.17), SYS_getrandom and SYS_seccomp are not defined, causing cgo compilation to fail. Note that there are already several types and defines copied from linux headers into seccomp_linux.go to support compilation on older systems.
08e6cdc
to
0a0020e
Compare
This PR (HEAD: 0a0020e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707777. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707777. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/707777. |
Message from Filippo Valsorda: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707777. |
Message from Doug MacEachern: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707777. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707777. |
This PR (HEAD: 412c349) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707777. Important tips:
|
Message from Doug MacEachern: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/707777. |
seccomp_linux.go is only used for Go's own tests (commit 6446285), but the package is included when building programs with CGO_ENABLED=1.
When using an older glibc (e.g. 2.17), SYS_getrandom and SYS_seccomp are not defined, causing cgo compilation to fail.
Note that there are already several types and defines copied from linux headers into seccomp_linux.go to support compilation on older systems.
Updates #69536