-
Couldn't load subscription status.
- Fork 18.4k
runtime,runtime/pprof: clean up goroutine leak profile writing #76045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
runtime,runtime/pprof: clean up goroutine leak profile writing #76045
Conversation
|
This PR (HEAD: 7f1c287) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714580. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/714580. |
7f1c287 to
9f938be
Compare
|
This PR (HEAD: 9f938be) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714580. Important tips:
|
|
Message from Georgian-Vlad Saioc: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/714580. |
|
Message from Georgian-Vlad Saioc: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/714580. |
|
Message from t hepudds: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/714580. |
|
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-27T11:25:05Z","revision":"b56ebcfe8ea10abbbd4dc11673785d168bf8f191"} Please don’t reply on this GitHub thread. Visit golang.org/cl/714580. |
|
Message from t hepudds: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/714580. |
|
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-386 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/714580. |
|
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/714580. |
|
This PR (HEAD: 8ddb8be) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714580. Important tips:
|
Cleaned up goroutine leak profile extraction:
doRecordGoroutineProfile, which had side-effects over
goroutineProfile fields.
Added regression tests for goroutine leak profiling frontend for binary
and debug=1 profile formats.
Added stress tests for concurrent goroutine and goroutine leak profile requests.