Skip to content

Commit

Permalink
http2: skip "write: broken pipe" failures in TestServer on OpenBSD
Browse files Browse the repository at this point in the history
This failure mode has been observed on openbsd/mips64 and
openbsd/arm64.

I have not diagnosed the precise root cause, but I suspect a platform
bug — perhaps a bad interaction with the relatively weakly-ordered
memory models on these CPUs.

For golang/go#52208.

Change-Id: I0ab0285cc395d22742ced8f28d5c9c3280fcd1e3
Reviewed-on: https://go-review.googlesource.com/c/net/+/398794
Trust: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
  • Loading branch information
Bryan C. Mills authored and gopherbot committed Apr 7, 2022
1 parent 749bd19 commit aac1ed4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions http2/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,10 @@ func (st *serverTester) writePreface() {

func (st *serverTester) writeInitialSettings() {
if err := st.fr.WriteSettings(); err != nil {
if runtime.GOOS == "openbsd" && strings.HasSuffix(err.Error(), "write: broken pipe") {
st.t.Logf("Error writing initial SETTINGS frame from client to server: %v", err)
st.t.Skipf("Skipping test with known OpenBSD failure mode. (See https://go.dev/issue/52208.)")
}
st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
}
}
Expand Down

0 comments on commit aac1ed4

Please sign in to comment.