Skip to content

idna: update from x/text - #269

Open
cristiangirlea wants to merge 1 commit into
golang:masterfrom
cristiangirlea:idna-update-from-x-text
Open

cristiangirlea wants to merge 1 commit into
golang:masterfrom
cristiangirlea:idna-update-from-x-text

Conversation

@cristiangirlea

Copy link
Copy Markdown

Changes produced by running the copyExported("golang.org/x/net/idna")
step of go generate in golang.org/x/text at 6dcc5b6.

This brings in CL 818802, which rejects xn-- labels that decode to an
empty label, as UTS #46 processing step 4 requires. Before, a name
such as "example.com.xn--" converted to "example.com." without an
error. It also brings in CL 818800 and CL 818801.

idna, http/httpguts, http/httpproxy, http2 and publicsuffix pass on
linux/amd64, also with -race, and idna on linux/386.

Fixes golang/go#81549

Changes produced by running the copyExported("golang.org/x/net/idna")
step of go generate in golang.org/x/text at 6dcc5b6.

This brings in CL 818802, which rejects xn-- labels that decode to an
empty label, as UTS golang#46 processing step 4 requires. Before, a name
such as "example.com.xn--" converted to "example.com." without an
error. It also brings in CL 818800 and CL 818801.

idna, http/httpguts, http/httpproxy, http2 and publicsuffix pass on
linux/amd64, also with -race, and idna on linux/386.

Fixes golang/go#81549
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: b416ace) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/839805.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/net/idna: Punycode decoding succeeds where it should not

2 participants