Repository navigation
http2: send 0 as the last stream ID in client GOAWAY - #270
Open
cristiangirlea wants to merge 1 commit into
Open
cristiangirlea wants to merge 1 commit into
cristiangirlea wants to merge 1 commit into
Conversation
Contributor
|
This PR (HEAD: bd07134) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/843165. Important tips:
|
cristiangirlea
marked this pull request as ready for review
October 3, 2026 18:33
The last stream ID in a GOAWAY frame refers to streams initiated by the peer that receives it (RFC 9113, Section 6.8). The client disables server push, so the server never initiates streams, and the client should send 0. sendGoAway sent the client's next stream ID instead, which is odd, and nghttp2 rejects the frame with a PROTOCOL_ERROR. This affects the implementation used before Go 1.27, or with the http2legacy build tag. Fixes golang/go#80759
cristiangirlea
force-pushed
the
fix-http2-client-goaway
branch
from
October 3, 2026 18:34
bd07134 to
046500d
Compare
Contributor
|
This PR (HEAD: 046500d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/843165. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last stream ID in a GOAWAY frame refers to streams initiated by
the peer that receives it (RFC 9113, Section 6.8). The client disables
server push, so the server never initiates streams, and the client
should send 0. sendGoAway sent the client's next stream ID instead,
which is odd, and nghttp2 rejects the frame with a PROTOCOL_ERROR.
This affects the implementation used before Go 1.27, or with the
http2legacy build tag.
Fixes golang/go#80759