Skip to content

http2: send 0 as the last stream ID in client GOAWAY - #270

Open
cristiangirlea wants to merge 1 commit into
golang:masterfrom
cristiangirlea:fix-http2-client-goaway
Open

cristiangirlea wants to merge 1 commit into
golang:masterfrom
cristiangirlea:fix-http2-client-goaway

Conversation

@cristiangirlea

Copy link
Copy Markdown

The last stream ID in a GOAWAY frame refers to streams initiated by
the peer that receives it (RFC 9113, Section 6.8). The client disables
server push, so the server never initiates streams, and the client
should send 0. sendGoAway sent the client's next stream ID instead,
which is odd, and nghttp2 rejects the frame with a PROTOCOL_ERROR.

This affects the implementation used before Go 1.27, or with the
http2legacy build tag.

Fixes golang/go#80759

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: bd07134) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/843165.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@cristiangirlea
cristiangirlea marked this pull request as ready for review October 3, 2026 18:33
The last stream ID in a GOAWAY frame refers to streams initiated by
the peer that receives it (RFC 9113, Section 6.8). The client disables
server push, so the server never initiates streams, and the client
should send 0. sendGoAway sent the client's next stream ID instead,
which is odd, and nghttp2 rejects the frame with a PROTOCOL_ERROR.

This affects the implementation used before Go 1.27, or with the
http2legacy build tag.

Fixes golang/go#80759
@cristiangirlea
cristiangirlea force-pushed the fix-http2-client-goaway branch from bd07134 to 046500d Compare October 3, 2026 18:34
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 046500d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/843165.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/net/http2: client GOAWAY uses an odd (client) Last-Stream-ID, rejected as PROTOCOL_ERROR by nghttp2 servers

2 participants