Skip to content

Commit

Permalink
cmd/vulncheck_compare: missing error branch
Browse files Browse the repository at this point in the history
Execution continued when `err != nil` and `binResp == nil`.
This was causing flakes on the LUCI builders

Change-Id: Ib3f9086b8315fc36b72745900720a572f2fbecce
Reviewed-on: https://go-review.googlesource.com/c/pkgsite-metrics/+/612915
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
  • Loading branch information
timothy-king committed Sep 13, 2024
1 parent e95c797 commit a76cee4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cmd/govulncheck_compare/govulncheck_compare.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ func run(w io.Writer, args []string) {
binResp, err := govulncheck.RunGovulncheckCmd(govulncheckPath, govulncheck.FlagBinary, binary.BinaryPath, modulePath, vulndbPath)
if err != nil {
pair.Error = err.Error()
continue
}
pair.BinaryResults = *binResp
pair.BinaryResults.Stats.BuildTime = binary.BuildTime
Expand Down

0 comments on commit a76cee4

Please sign in to comment.