gopls/internal/analysis/modernize: fix slicedelete triggers on slice identifiers with side effects

[ashurbekovz]

Add a check that the expression defining the slice has no side effects to trigger slicedelete. This is a necessary condition to ensure that the change does not change the program behavior.

Fixes golang/go#72955

[gopherbot]

This PR (HEAD: 4393fcb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/659295.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from Gopher Robot:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alan Donovan:

Patch Set 3:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alan Donovan:

Patch Set 3:

(4 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alan Donovan:

Patch Set 3:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: ca10c13) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/659295.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

This PR (HEAD: 9fedd25) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/659295.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from Zamir Ashurbekov:

Patch Set 4:

(5 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alan Donovan:

Patch Set 6:

(7 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 54e9082) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/659295.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from Zamir Ashurbekov:

Patch Set 7:

(5 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alan Donovan:

Patch Set 7: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-21T20:15:10Z","revision":"d0d0a8e42c27f117d33afe7eb580d959f0229903"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Alan Donovan:

Patch Set 7: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Zamir Ashurbekov:

Patch Set 7: Code-Review+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/659295.
After addressing review feedback, remember to publish your drafts!