Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve formatter messages #5243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 21, 2024

The formaters are not classic linter, it makes no sense to use exclusions for them, so I think nobody (or at least very very few people) will be affected by this change.

IMHO, we don't need to create a v2 to change those messages.

Fixes #138

@ldez ldez added the linter: update Update the linter implementation inside golangci-lint label Dec 21, 2024
@ldez ldez added this to the next milestone Dec 21, 2024
@ldez ldez force-pushed the fix/formatter-messages branch from 91ededf to 59b16cc Compare December 21, 2024 23:43
@ccoVeille
Copy link
Contributor

Good changes.

The messages with gci-ed and gofumpt-ed confused some of my colleagues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confusing error message "File is not goimports-ed (goimports)"
4 participants