log stacktrace when panic

golangid · Jun 14, 2023 · 7875e4f · 7875e4f
1 parent 8ecd3ab
commit 7875e4f
Show file tree

Hide file tree

Showing 11 changed files with 12 additions and 24 deletions.
diff --git a/codebase/app/cron_worker/cron_worker.go b/codebase/app/cron_worker/cron_worker.go
@@ -9,7 +9,6 @@ import (
 	"fmt"
 	"log"
 	"reflect"
-	"runtime/debug"
 	"sync"
 	"time"
 
@@ -180,7 +179,7 @@ func (c *cronWorker) processJob(job *Job) {
 	defer func() {
 		if r := recover(); r != nil {
 			trace.SetError(fmt.Errorf("%v", r))
-			trace.Log("stacktrace", string(debug.Stack()))
+			tracer.LogStackTrace(trace)
 		}
 		logger.LogGreen("cron_scheduler > trace_url: " + tracer.GetTraceURL(ctx))
 		trace.SetTag("trace_id", tracer.GetTraceID(ctx))

diff --git a/codebase/app/grpc_server/grpc_server.go b/codebase/app/grpc_server/grpc_server.go
@@ -98,7 +98,7 @@ func NewServer(service factory.ServiceFactory, opts ...OptionFunc) factory.AppSe
 
 func (s *grpcServer) Serve() {
 	if err := s.serverEngine.Serve(s.listener); err != nil {
-		log.Panicf("GRPC: Unexpected Error: %v", err)
+		log.Println("GRPC: Unexpected Error", err)
 	}
 }
 

diff --git a/codebase/app/kafka_worker/default_handler.go b/codebase/app/kafka_worker/default_handler.go
@@ -3,7 +3,6 @@ package kafkaworker
 import (
 	"fmt"
 	"log"
-	"runtime/debug"
 	"strconv"
 	"sync"
 	"time"
@@ -71,7 +70,7 @@ func (c *consumerHandler) processMessage(session sarama.ConsumerGroupSession, me
 	defer func() {
 		if r := recover(); r != nil {
 			trace.SetError(fmt.Errorf("%v", r))
-			trace.Log("stacktrace", string(debug.Stack()))
+			tracer.LogStackTrace(trace)
 		}
 
 		if handler.AutoACK {

diff --git a/codebase/app/postgres_worker/connection.go b/codebase/app/postgres_worker/connection.go
@@ -11,7 +11,6 @@ import (
 )
 
 func getListener(dsn string) (*sql.DB, *pq.Listener) {
-
 	db, err := sql.Open("postgres", dsn)
 	if err != nil {
 		panic(fmt.Errorf(`[POSTGRES-LISTENER] ERROR: %v, connection: %s`, err, candihelper.MaskingPasswordURL(dsn)))

diff --git a/codebase/app/postgres_worker/postgres_worker.go b/codebase/app/postgres_worker/postgres_worker.go
@@ -7,7 +7,6 @@ import (
 	"fmt"
 	"log"
 	"reflect"
-	"runtime/debug"
 	"strconv"
 	"sync"
 
@@ -119,7 +118,6 @@ func NewWorker(service factory.ServiceFactory, opts ...OptionFunc) factory.AppSe
 }
 
 func (p *postgresWorker) Serve() {
-
 	for _, source := range p.opt.sources {
 		source.listener.Listen(eventsConst)
 	}
@@ -216,7 +214,7 @@ func (p *postgresWorker) execEvent(workerIndex int, data *EventPayload) {
 	defer func() {
 		if r := recover(); r != nil {
 			trace.SetError(fmt.Errorf("panic: %v", r))
-			trace.Log("stacktrace", string(debug.Stack()))
+			tracer.LogStackTrace(trace)
 		}
 		logger.LogGreen("postgres_listener > trace_url: " + tracer.GetTraceURL(ctx))
 		trace.SetTag("trace_id", tracer.GetTraceID(ctx))
@@ -233,7 +231,6 @@ func (p *postgresWorker) execEvent(workerIndex int, data *EventPayload) {
 
 	if data.Data.IsTooLongPayload {
 		detailData := source.findDetailData(data.Table, data.GetID())
-
 		switch data.Action {
 		case ActionInsert:
 			data.Data.New = detailData

diff --git a/codebase/app/postgres_worker/sources.go b/codebase/app/postgres_worker/sources.go
@@ -65,7 +65,6 @@ func (p *PostgresSource) execTriggerQuery(tableName string) error {
 }
 
 func (p *PostgresSource) findDetailData(tableName, id string) interface{} {
-
 	rows, err := p.db.Query(`SELECT * FROM `+tableName+` WHERE id=$1`, id)
 	if err != nil {
 		return nil
@@ -79,7 +78,7 @@ func (p *PostgresSource) findDetailData(tableName, id string) interface{} {
 
 	results := make(map[string]interface{}, len(columns))
 	if rows.Next() {
-		values := make([]string, len(columns))
+		values := make([]interface{}, len(columns))
 		columnVals := make([]interface{}, len(columns))
 		for i := range values {
 			columnVals[i] = &values[i]

diff --git a/codebase/app/rabbitmq_worker/rabbitmq_worker.go b/codebase/app/rabbitmq_worker/rabbitmq_worker.go
@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"log"
 	"reflect"
-	"runtime/debug"
 	"sync"
 
 	"github.com/golangid/candi/candihelper"
@@ -153,7 +152,7 @@ func (r *rabbitmqWorker) processMessage(message amqp.Delivery) {
 	defer func() {
 		if r := recover(); r != nil {
 			err = fmt.Errorf("panic: %v", r)
-			trace.Log("stacktrace", string(debug.Stack()))
+			tracer.LogStackTrace(trace)
 		}
 
 		if selectedHandler.AutoACK {

diff --git a/codebase/app/redis_worker/redis_worker.go b/codebase/app/redis_worker/redis_worker.go
@@ -7,7 +7,6 @@ import (
 	"context"
 	"fmt"
 	"log"
-	"runtime/debug"
 	"sync"
 
 	"github.com/golangid/candi/broker"
@@ -172,7 +171,7 @@ func (r *redisWorker) processMessage(param broker.RedisMessage) {
 	defer func() {
 		if r := recover(); r != nil {
 			trace.SetError(fmt.Errorf("panic: %v", r))
-			trace.Log("stacktrace", string(debug.Stack()))
+			tracer.LogStackTrace(trace)
 		}
 		logger.LogGreen("redis_subscriber > trace_url: " + tracer.GetTraceURL(ctx))
 		trace.SetTag("trace_id", tracer.GetTraceID(ctx))

diff --git a/codebase/app/task_queue_worker/trigger_task.go b/codebase/app/task_queue_worker/trigger_task.go
@@ -121,7 +121,7 @@ func (t *taskQueueWorker) execJob(ctx context.Context, runningTask *Task) {
 			job.Error = err.Error()
 			job.Status = string(StatusFailure)
 
-			tracer.LogStackTraceWhenPanic(trace)
+			tracer.LogStackTrace(trace)
 		}
 
 		job.FinishedAt = time.Now()

diff --git a/tracer/tracer.go b/tracer/tracer.go
@@ -73,12 +73,12 @@ func GetTraceURL(ctx context.Context) (u string) {
 	return activeTracer.GetTraceURL(ctx)
 }
 
-// LogStackTraceWhenPanic log stack trace in recover panic
-func LogStackTraceWhenPanic(trace Tracer) {
+// LogStackTrace log stack trace in recover panic
+func LogStackTrace(trace Tracer) {
 	const size = 2 << 10
 	buf := make([]byte, size)
 	buf = buf[:runtime.Stack(buf, false)]
-	trace.Log("panic_trace", buf)
+	trace.Log("stacktrace_detail", buf)
 }
 
 type noopTracer struct{ ctx context.Context }

diff --git a/wrapper/http_handler.go b/wrapper/http_handler.go
@@ -59,7 +59,7 @@ func HTTPMiddlewareTracer(cfg HTTPMiddlewareTracerConfig) func(http.Handler) htt
 			trace, ctx := tracer.StartTraceFromHeader(req.Context(), operationName, header)
 			defer func() {
 				if rec := recover(); rec != nil {
-					tracer.LogStackTraceWhenPanic(trace)
+					tracer.LogStackTrace(trace)
 					NewHTTPResponse(http.StatusInternalServerError, fmt.Sprintf("panic: %v", rec)).JSON(rw)
 				}
 				trace.SetTag("trace_id", tracer.GetTraceID(ctx))
@@ -197,9 +197,6 @@ func HTTPMiddlewareLog(isActive bool, writer io.Writer) func(http.Handler) http.
 
 			buf.WriteString(`","id":"`)
 			id := req.Header.Get("X-Request-ID")
-			if id == "" {
-				id = res.Header().Get("X-Request-ID")
-			}
 			buf.WriteString(id)
 
 			buf.WriteString(`","remote_ip":"`)