Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: add initial support for volume override #186

Closed
wants to merge 22 commits into from

Conversation

kamirr
Copy link
Contributor

@kamirr kamirr commented Aug 22, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2024

CLA assistant check
All committers have signed the CLA.

* Emit cmdline for each mount:
  * storage: vol-{k}={path}[,errors={errors}]:{device id}
  * ram: vol-{k}={path},size={size}
* Minimal implementation of qcow2 to create files for storage.
* Emit nvidia=true cmdline to signify that the last vdX is the nvidia
  drive.
@kamirr kamirr requested review from prekucki and aljen August 27, 2024 11:18
@kamirr kamirr force-pushed the kek/vol-override-poc2 branch 2 times, most recently from 5db4dea to f5e49ea Compare August 27, 2024 11:21
* Assign serial numbers of the form vol-{k} to identify external
  storage.
* Emit command line parameters vol-{k}-path=.. and vol-{k}-errors for
  each of the external drives.
* Split tmpfs specification into vol-{k}-path=.. and vol-{k}-size.
* Assign serial `vol-nvidia` to the nvidia files drive.
* Don't emit command line nvidia=true
* self-test didn't remove its artifacts from /tmp, which wasn't harmful
  when those were only directories but with the introduction of qcow2
  storage, the storage leak became considerable. Now each invocation of
  the self-test creates it's dedicated subdirectory within /tmp which is
  deleted after the test concludes.
* lower storage sizes for self-test.
* Temporarily disable nvidia storage support
Extra:
* hide mkfs.ext2 output
* validate that the failure to open /sys/class/block/vdX/serial is
  reported as the absence of the file only when errno is ENOENT. Fail
  otherwise.
@kamirr
Copy link
Contributor Author

kamirr commented Sep 3, 2024

Superseded by #187

@kamirr kamirr closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants