Disable read timeout for Pub/Sub connections #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the nature Pub/Sub connections they highly likely to block on reads for long periods hence it doesn't make sense to apply any read timeout configured on the pool to Pub/Sub connections.
|
For reference the alternative to this would be to test errors return by PubSubConn.Receive() in all consumers to check for net.Error.Timeout() == true and ignore them, which while possible isn't very idiomatic. |
Implemented ReceiveNoReadTimeout required by Conn since the change to disable read timeout on Pub/Sub connections.
|
I am rejecting this PR because this is a breaking change. Also, ReadWithoutTimeout is not useful in a robust application. PING with a duration shorter than the read timeout. |
|
I suspected this may be the case, something else to try an solve with the high level API We'll keep this internally so we don't have to update all consumers until the new Pub/Sub API is available. |
|
See #298 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the nature Pub/Sub connections they highly likely to block on reads for long periods hence it doesn't make sense to apply any read timeout configured on the pool to Pub/Sub connections.