New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike for SubscriptionReader #336

Closed

nelz9999 wants to merge 1 commit into gomodule:master from nelz9999:subs-reader

nelz9999 commented Apr 27, 2018

Related to #296

This is potential helper functionality for using PubSub. (I did this as a PR instead of an Issue, just so folks could see what I was talking about.)

I expect the responses may include:

"Great, but it's overly specific/opinionated..."
- "... so maybe make it more generic or more configurable."
- "... so we don't want it in the main project, but maybe in a helper/examples package."
"Looks good, but need docs and the unit tests." (Happy to do! Just wanted some direction before investing more time.)

Whaddya think?


          Spike for SubscriptionReader

6aa689b

Author

nelz9999 commented Apr 29, 2018

(I just realized I screwed up the semantics of WriteTo, which I'll fix in the full-er checkin.)

nelz9999 closed this

nelz9999 deleted the subs-reader branch

May 5, 2018 19:38

gomodule locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet