-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tests for Diameter and SIP Port decoding preferences #8
Conversation
70da2e6
to
b6591ea
Compare
Hi @dipeshwalia I looked at the The prefs you mentioned appear to be on the list: /* These are obsolete preferences from the dissectors' view,
(typically because of a switch from a single value to a
range value) but the name of the preference conflicts
with the generated preference name from the dissector table.
Don't allow the obsolete preference through to be handled */
struct obsolete_pref_name obsolete_prefs[] = {
{"diameter.tcp.port"},
{"kafka.tcp.port"},
{"mrcpv2.tcp.port"},
{"rtsp.tcp.port"},
{"sip.tcp.port"},
{"t38.tcp.port"},
}; The Wireshark QT UI doesn't use Is there a way you can reproduce this with |
Hi @dehydr8, I am attaching a sample pcap that I used to test tshark decode preference.
with decode
Let me know if I missed something. Thank you |
Hi @dipeshwalia It appears that We do not touch any I have added a special case for handling Let me know if it works for you. |
Hi @dehydr8 Thank you for this patch; I can confirm my early results worked. I'll play deeper and keep you posted. |
@dehydr8 Thank you. We are good with this change. I tested it on a bunch of cases, and there have been no issues so far. Thank you so much for your support. Do you have Discord, Slack, or some other community account? We would love to connect |
Awesome, I'll merge it then. I currently don't, but can create a Discord server for good.tools, with a Edit: Here's the link to the invite: https://discord.gg/wfdVbNaM |
🎉 This PR is included in version 1.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hello folks,
Thank you for reading the following PR.
We are using set preferences and notice some protocols are not correctly decoded.
I have tried to add a test PR to show the failing issue. Please advise me if I am missing something.
CI results can be viewed here
cc @dehydr8 for your attention.
Thank you so much again for your time.
Note: I modified the make file to make c-ares-1.15.0 worked for ci to run tests.