check password format in Password assessor (#230)

goodwithtech · Jul 9, 2023 · e90eb9d · e90eb9d
1 parent 53e0295
commit e90eb9d
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/pkg/assessor/passwd/passwd.go b/pkg/assessor/passwd/passwd.go
@@ -30,9 +30,13 @@ func (a PasswdAssessor) Assess(fileMap deckodertypes.FileMap) ([]*types.Assessme
 		scanner := bufio.NewScanner(bytes.NewBuffer(file.Body))
 		for scanner.Scan() {
 			line := scanner.Text()
+			if len(line) == 0 || line[0] == '#' {
+				continue
+			}
 			passData := strings.Split(line, ":")
-			// password must given
-			if passData[1] == "" {
+			if len(passData) < 2 {
+				log.Logger.Debug("The password format may be invalid.", line)
+			} else if passData[1] == "" {
 				assesses = append(
 					assesses,
 					&types.Assessment{