Restructure Kotlin APIs to Share Common Code in core/#2726
Open
rbebb wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- The goal is to prep the Kotlin APIs for Kotlin Multiplatform use - Platform specific Engine implementations are marked as internal, but the API to create and use an Engine is still the same - LiteRtLmJniException changed to LiteRtLmNativeException to better reflect the intent for eventual multiplatform support
d07a1c8 to
39ad456
Compare
rbebb
commented
Jul 5, 2026
| } | ||
| ``` | ||
|
|
||
| #### Multiplatform |
Author
There was a problem hiding this comment.
I assume a -core package won't be published just yet, so this multiplatform section might not be necessary for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this is to prep the Kotlin APIs for eventual Kotlin Multiplatform support. For now, that just means that common code is shared in core/.
Also, the Kotlin rules for Bazel don’t support Kotlin Multiplatform yet (see this GitHub Issue for updates) so that's why I didn't use Kotlin Multiplatform's
expect/actualsyntax. Once the Kotlin rules for Bazel do add support, the code can be simplified a bit.Changes
Questions/Comments