Fix SWA local layer silent exit by implementing ring buffer#2762
Draft
enlenama wants to merge 1 commit into
Draft
Fix SWA local layer silent exit by implementing ring buffer#2762enlenama wants to merge 1 commit into
enlenama wants to merge 1 commit into
Conversation
For Sliding Window Attention models, local layers have smaller KV cache (e.g. 1K) than global layers (e.g. 16K). Previously, when decode position exceeded cache capacity, HWKVCacheUpdate returned OutOfRangeError which propagated through the task loop causing silent exit. Fix: wrap position modulo cache_seq (ring buffer) instead of returning error. Handle prefill wrap-around with split memcpy for cases where the write spans the cache boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Sliding Window Attention models, local layers have smaller KV cache (e.g. 1K) than global layers (e.g. 16K). Previously, when decode position exceeded cache capacity, HWKVCacheUpdate returned OutOfRangeError which propagated through the task loop causing silent exit.
Fix: wrap position modulo cache_seq (ring buffer) instead of returning error. Handle prefill wrap-around with split memcpy for cases where the write spans the cache boundary.