Skip to content

fix(examples): replace unsafe eval in title.sh with safe read block #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbhiPra24 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(examples): replace unsafe eval in title.sh with safe read block #872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions examples/title/title.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,16 @@ set -euo pipefail
# Read JSON payload from stdin
DATA=$(cat)

# Extract fields using jq
eval $(echo "$DATA" | jq -r '
"STATE=\"\(.agent_state // "idle")\"
CWD=\"\(.workspace.current_dir // "")\"
"
' 2>/dev/null || echo 'STATE="idle" CWD=""')
# Extract fields using jq safely without eval
{
read -r STATE
read -r CWD
} <<< "$(
echo "$DATA" | jq -r '
(.agent_state // "idle"),
(.workspace.current_dir // "")
' 2>/dev/null || printf "idle\n\n"
)"

# Try to extract CitC workspace name from CWD
if [ -n "$CWD" ]; then
Expand Down