Skip to content

fix: clarify assert_shape error when bare Ellipsis is passed #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PewterZz wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

fix: clarify assert_shape error when bare Ellipsis is passed #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions chex/_src/asserts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,10 @@ def assert_shape(
match; if ``expected_shapes`` has wrong type; if shape of ``input`` does
not match ``expected_shapes``.
"""
if expected_shapes is Ellipsis:
raise AssertionError(
"Error in shape compatibility check: `...` must be wrapped in a tuple, "
"e.g. `(...,)` not `...`.")
if not isinstance(expected_shapes, (list, tuple)):
raise AssertionError(
"Error in shape compatibility check: expected shapes should be a list "
Expand Down