Make trace dispatch purely a function of context rather than a function of both context and data. This lets us delete a lot of machinery for managing data-dependent tracing: levels, sublevels, post_process_call, new_base_main, custom_bind and so on. #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_681582933
branch
15 times, most recently
from
1ca4711
to
1e3ff9a
Compare
copybara-service
bot
force-pushed
the
test_681582933
branch
11 times, most recently
from
ab5c6d4
to
561a850
Compare
copybara-service
bot
force-pushed
the
test_681582933
branch
4 times, most recently
from
59afd00
to
463c5bf
Compare
copybara-service
bot
force-pushed
the
test_681582933
branch
3 times, most recently
from
1a5d802
to
6aee3f3
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_681582933
branch
18 times, most recently
from
a0a7aab
to
5c79b0c
Compare
…on of both context and data. This lets us delete a lot of machinery for managing data-dependent tracing: levels, sublevels, post_process_call, new_base_main, custom_bind and so on. PiperOrigin-RevId: 691086496
copybara-service
bot
force-pushed
the
test_681582933
branch
from
5c79b0c
to
72c6db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make trace dispatch purely a function of context rather than a function of both context and data. This lets us delete a lot of machinery for managing data-dependent tracing: levels, sublevels, post_process_call, new_base_main, custom_bind and so on.