Skip to content

Migrate voice-memos.ipynb to use new google-genai sdk from google-generative-ai sdk #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Chamikajaya
Copy link

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Mar 22, 2025
@@ -3,18 +3,17 @@
{
Copy link
Collaborator

@Giom-V Giom-V Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.      model='gemini-2.0-flash',

Can you add a "MODEL_ID" variable like this?

MODEL_ID="gemini-2.0-flash" # @param ["gemini-2.0-flash-lite","gemini-2.0-flash","gemini-2.0-pro-exp-02-05"] {"allow-input":true, isTemplate: true}

As it would make the notebook easier to maintain in the future.


Reply via ReviewNB

@@ -3,18 +3,17 @@
{
Copy link
Collaborator

@Giom-V Giom-V Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #3.      contents=[prompt, blog_file, blog_file2, audio_file ],

Ntipicking, but can you remove the extra space at the end?


Reply via ReviewNB

@Giom-V
Copy link
Collaborator

Giom-V commented Mar 31, 2025

Thanks @Chamikajaya for the submission and sorry for the delayed review.

I just added a couple of minor comments to make the notebook easier to understand and to maintain.

Can you also check the lint and format failures and fix them (format is likely because you haven't run the formatting script, lint because a "we" needs to be changed into a "you"). If you see a lint error reported in the template notebook, just ignore it, it's because of a CL you merged with.

Thanks again!

@andycandy
Copy link
Contributor

@Giom-V If this PR has been abandoned, I can take continue this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:examples Issues/PR referencing examples folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants