-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Migrate voice-memos.ipynb to use new google-genai sdk from google-generative-ai sdk #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Chamikajaya
commented
Mar 22, 2025
- Voice_memos.ipynb was updated to use all new google-genai sdk
- References used for the migration to new sdk- https://ai.google.dev/gemini-api/docs/migrate
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -3,18 +3,17 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #2. model='gemini-2.0-flash',
Can you add a "MODEL_ID" variable like this?
MODEL_ID="gemini-2.0-flash" # @param ["gemini-2.0-flash-lite","gemini-2.0-flash","gemini-2.0-pro-exp-02-05"] {"allow-input":true, isTemplate: true}
As it would make the notebook easier to maintain in the future.
Reply via ReviewNB
@@ -3,18 +3,17 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #3. contents=[prompt, blog_file, blog_file2, audio_file ],
Ntipicking, but can you remove the extra space at the end?
Reply via ReviewNB
Thanks @Chamikajaya for the submission and sorry for the delayed review. I just added a couple of minor comments to make the notebook easier to understand and to maintain. Can you also check the lint and format failures and fix them (format is likely because you haven't run the formatting script, lint because a "we" needs to be changed into a "you"). If you see a lint error reported in the template notebook, just ignore it, it's because of a CL you merged with. Thanks again! |
@Giom-V If this PR has been abandoned, I can take continue this |