chore: refactored test-helper to handle boilerplate for interactive mode #10322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nteractive' into hriday/chat_compress_intg_test_interactive
|
Size Change: -2 B (0%) Total Size: 17.5 MB ℹ️ View Unchanged
|
jacob314
reviewed
Oct 1, 2025
integration-tests/test-helper.ts
Outdated
| }> { | ||
| const { ptyProcess, promise } = this.runInteractive(); | ||
|
|
||
| const authDialogAppeared = await this.waitForText( |
There was a problem hiding this comment.
rather than timing out 5 seconds for the auth prompt, lets end early if "Type your message" appears. You could achieve this by customizing waitForText to take multiple strings returning the one that matched or writing a custom waitFor for just this case with the appropriate more complex logic.
that way we avoid a 5 second timeout just for auth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
While running integration tests in interactive mode, the auth dialog was showing up on start up. To handle this auth dialog and wait till the cli is ready for input is handled in a new method now in test-helper.
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs