-
Notifications
You must be signed in to change notification settings - Fork 7.9k
docs: document custom witty loading phrases feature #8006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: document custom witty loading phrases feature #8006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @JayadityaGit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing user customization by documenting the new "Custom Witty Loading Phrases" feature. It provides clear instructions on how users can configure their CLI to display personalized loading messages, thereby improving the user experience and awareness of this new capability.
Highlights
- New Configuration Setting Documented: The ui.customWittyPhrases setting has been documented in docs/cli/configuration.md, detailing its purpose as an array of strings for custom loading messages.
- Configuration Example Updated: The example settings.json file has been updated to include an example usage of the ui.customWittyPhrases setting.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces documentation for the ui.customWittyPhrases
feature, including its description in docs/cli/configuration.md
and an example in settings.json
. I have reviewed the changes and provided feedback to address a potential issue.
LG from me with one comment. Passing up to the next reviewer for final. |
I’ve run the preflight command, so the lint issue should be resolved. |
I know the line originates from Rockstar Games, but I included it as it feels like a human expression, meant respectfully. For me, it resonates most in moments like a sudden API error or an LLM hallucination. |
I can appreciate an homage to good video game, and I think this one is a bit more subtle 👍 |
tag @cornmander for final. |
TLDR
This pull request documents the new Custom Witty Loading Phrases feature.
It introduces the
ui.customWittyPhrases
setting indocs/cli/configuration.md
and updates the examplesettings.json
accordingly.Dive Deeper
ui.customWittyPhrases
to the configuration reference.settings.json
example to include witty phrases.This documentation work ensures users are aware of the new customization option introduced by the feature.
Testing Matrix
Linked issues / bugs
Related to #7782 — this feature currently has a bug.
I would kindly suggest reviewing it first, since it attempts to solve a major bug in the feature.