-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blevitan dev - Retry Logic #126
base: main
Are you sure you want to change the base?
Conversation
…And confirm it was properly scheduled.
…sses to separate module and file. Got retries.py working to schedule dynamic dags.
…otFound exception on retry delete.
…e connections after a few days.
…ause issues after a few days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but noted some potential problems and nits below.
PTAL and rebase with the latest changes so that I can take a new look please!
run_result += target_destination.send_data(data, dry_run) | ||
offset += batch_size | ||
## TESTING ONLY ###################################################### | ||
# TODO(blevitan): REMOVE this line before merging BLEVITAN_DEV branch into MAIN. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove when done testing on rebase.
Here is a pull request for the retry logic. I haven't done any testing yet and probably won't have a chance to revisit this for a few weeks, but I wanted to get the code in your hands if you have time to review.