Skip to content

Conversation

emilyfertig
Copy link
Contributor

Could someone please help me define the lower-triangular chol_cov in stats-tests? Everything I've tried throws either a type error or a compiler bug (let me know if you want me to file an issue for the latter). Thanks!

@axch
Copy link
Collaborator

axch commented Jul 25, 2023

I can't reproduce the compiler bug. All three of the examples you have in stats-tests.dx seem to work fine:

chol_cov_mat : Fin 2=>Fin 2=>Float = [[0.2, 0.], [-0.3, 0.1]]
chol_cov1 = for i:(Fin 2). for j:(..i). chol_cov_mat[i, inject(to=Fin 2, j)]
chol_cov2 = for i:(Fin 2). for j:(..i). chol_cov_mat[i, (ordinal j)@_]
chol_cov3 = for i:(Fin 2). for j:(..i). chol_cov_mat[i, inject j]

Perhaps you need a dex clean? make just-build doesn't do that by default because it triggers a (slow-ish) recompilation of the prelude, but if you don't clean when the Dex source changes, you can get weird incompatibilities sometimes.

As for the type error from trying to write a triangular literal directly, that was broken intentionally by PR #1207, because the machinery to support the feature was too heavy. The recommended idiom now is to just use coerce_table, thus:

chol_cov : (i:Fin 2)=>(..i)=>Float = [
  coerce_table _ [0.2],
  coerce_table _ [-0.3, 0.1]]

@emilyfertig
Copy link
Contributor Author

Thanks -- I ran dex clean and defining chol_cov works for me now. I'm seeing the compiler bug below. Let me know if you have any ideas for a workaround (or if I should file a Github issue).

-- multivariate normal                                        (
                                                              (
chol_cov : (i:Fin 2)=>(..i)=>Float = [                        (
  coerce_table _ [0.2],                                       (
  coerce_table _ [-0.3, 0.1]]                                 (
                                                              (
-- chol_cov_mat : Fin 2=>Fin 2=>Float = [[0.2, 0.], [-0.3, 0. (
-- chol_cov = for i:(Fin 2). for j:(..i). chol_cov_mat[i, inj (
                                                              (
loc : (Fin 2=>Float) = [1., 2.]                               (
draw (MultivariateNormal loc chol_cov) (new_key 0) :: (Fin 2= (
> [0.706645, 2.599938]                                        | > Compiler bug!
                                                              > > Please report this at github.com/google-research/dex-lang/i
                                                              > >
                                                              > > Unexpected table: chol_co
                                                              > > CallStack (from HasCallStack):
                                                              > >   error, called at src/lib/Simplify.hs:570:22 in dex-0.1.0.
                                                              (
ln (density (MultivariateNormal [1., 1] chol_cov) [0.5, 0.5]) (
> True                                                        | > Compiler bug!
                                                              > > Please report this at github.com/google-research/dex-lang/i
                                                              > >
                                                              > > Unexpected table: chol_co
                                                              > > CallStack (from HasCallStack):
                                                              > >   error, called at src/lib/Simplify.hs:570:22 in dex-0.1.0.
                                         
``

@axch
Copy link
Collaborator

axch commented Jul 26, 2023

Looks like a legit bug, which I minimized and refiled as #1333, but I don't know how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants