Skip to content

Commit

Permalink
Make zeta compile off google3
Browse files Browse the repository at this point in the history 
- I tested this on my linux cloudtop workstation
- This entails adding a lot of -Wno... flags
  • Loading branch information
Andrew Ferraiuolo committed Nov 15, 2022
1 parent 7054e0a commit 9749298
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions .bazelrc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,22 @@ build --host_cxxopt='-Wno-deprecated-declarations'
build --cxxopt='-Wno-thread-safety-precise'
build --host_cxxopt='-Wno-thread-safety-precise'

# These warnings must be disabled to run ZetaSQL on either linux or Mac off of google3.

This comment has been minimized.

Sign in to view

Copy link
@bgogul

bgogul Nov 16, 2022

Collaborator

What do you mean by off of google3?

Also, I thought Mark added all the necessary -Wno options? Wasn't that sufficient?
build --cxxopt='-Wno-address'
build --host_cxxopt='-Wno-address'
build --cxxopt='-Wno-deprecated-copy'
build --host_cxxopt='-Wno-deprecated-copy'
build --cxxopt='-Wno-array-compare'
build --host_cxxopt='-Wno-array-compare'
build --cxxopt='-Wno-cpp'
build --host_cxxopt='-Wno-cpp'
build --cxxopt='-Wno-format-overflow'
build --host_cxxopt='-Wno-format-overflow'
build --cxxopt='-Wno-return-type'
build --host_cxxopt='-Wno-return-type'
build --cxxopt='-Wno-class-memaccess'
build --host_cxxopt='-Wno-class-memaccess'

# Need this for ZetaSQL's icu dependency as long as it remains at version 65.
# Should remove when it gets upgraded.
build --cxxopt='-Wno-implicit-int-float-conversion'
Expand Down

0 comments on commit 9749298

Please sign in to comment.