Remove unused visibility specs (last referenced in codebase over 433 days ago) #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…days ago) * You may notice rules being explicitly set to `visibility = ["//visibility:private"]` even with no `default_visibility` being defined in the `BUILD` file. Please see go/scheuklappen#explicit-private for an explanation. * If you receive a CL that sets every rule in a package to private and would like to delete the package instead, please REVERT the CL and create a follow-up CL removing the directory yourself. Scheuklappen does not directly support this. * Only private by automation, not intent. Owner may accept CLs adding visibility. * go/scheuklappen for more information on this change. See go/scheuklappen-lsc for more information on why you've received this change and why it is important. This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/scheuklappen-bug for category BuildVisibility if there's an issue with the CL content. * File a bug under go/rosie-bug if there's an issue with how the CL was managed. * For all other issues such as the formatting of the CL, please file a bug under go/clrobot-bug. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/METADATA by following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 706069750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused visibility specs (last referenced in codebase over 433 days ago)
visibility = ["//visibility:private"]even with nodefault_visibilitybeing defined in theBUILDfile. Please see go/scheuklappen#explicit-private for an explanation.See go/scheuklappen-lsc for more information on why you've received this change and why it is important.
This CL looks good? Just LGTM and Approve it!
This CL doesn’t look good? This is what you can do:
go/clrobot-bug.
replying "BLOCKLIST: ". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.
This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/METADATA by
following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug
at go/clrobot-bug.
#codehealth