Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the a2ui-swiftui renderer to a2ui-swift and updates its platform designation to 'Apple' in the ecosystem documentation. Feedback suggests that the change is incomplete, as there are remaining references to the old name and platform in other sections of docs/ecosystem/renderers.md and in README.md that should be updated for consistency.
| | **@zhama/a2ui** | React (Web) | ✅ | ❌ | — | [npm](https://www.npmjs.com/package/@zhama/a2ui) | | ||
| | **A2UI-react** | React (Web) | ✅ | ❌ |   | [GitHub](https://github.com/jem-computer/A2UI-react) | | ||
| | **a2ui-swiftui** | SwiftUI (iOS, iPadOS, macOS, tvOS, watchOS, visionOS) | ✅ | ✅ |   | [GitHub](https://github.com/BBC6BAE9/a2ui-swiftui) | | ||
| | **a2ui-swift** | Apple (iOS, iPadOS, macOS, tvOS, watchOS, visionOS) | ✅ | ✅ |   | [GitHub](https://github.com/BBC6BAE9/a2ui-swift) | |
Contributor
There was a problem hiding this comment.
While the renderer name and platform have been updated in this table, there are inconsistencies in other parts of the documentation that should also be addressed for this change to be complete.
For example:
- In this file (
docs/ecosystem/renderers.md), line 36 still refers toa2ui-swiftuiand describes it as anative SwiftUI renderer. This should be updated toa2ui-swiftand reflect the platform change fromSwiftUItoApple. - In
README.md, line 169 still refers toiOS (SwiftUI)in the roadmap section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change name from A2UI-SwiftUI to A2UI-Swift
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.