Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to prune unused common types from the A2uiCatalog schema by implementing a new private method, _with_pruned_common_types, which identifies reachable definitions through a breadth-first search of schema references. A corresponding test case has been added to ensure that only referenced types are retained. A performance improvement was suggested to replace the list-based queue with collections.deque for more efficient popping during the reference collection process.
jiahaog
force-pushed
the
treeshaek
branch
2 times, most recently
from
c9cc5f5 to
2eae4f1
Compare
Member
Author
|
@nan-yu can you take a look? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Today, the system prompt includes common types schemas that may not be used by catalog or server to client schemas. This results in unnecessary input tokens.
Drop the whole common types schema section from the prompt if there are no common types.
Towards #1004.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.