Add interface to access V8-only error method.#808
Conversation
There was a problem hiding this comment.
Code Review
The pull request updates the package version to 0.8.5 and introduces a V8ErrorConstructor interface to correctly type and access the V8-specific captureStackTrace method on the Error object within the A2uiError class, improving type safety. A review comment suggests an improvement to use the 'captureStackTrace' in Error operator for checking property existence, which is more idiomatic and readable than casting Error within the conditional.
|
(Actually, I'm going to duplicate this error class into the v0_8 renderer, so there's no need to cross import from 0_9 into 0_8) |
|
PTAL @gspencergoog, I duplicated the errors.js class into 0_8 so we don't need to take a dependency from 0_9 just for the errors class (that was the only instance I could find where we're importing from 0_9 into 0_8) |
Description
Add interface to access V8-only error method.
(Unblocks cl/880945339)
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.