refactor: rename sandbox_iframe directory to mcp_apps_inner_iframe

[sugoi-yuzuru]

Description

Rename sandbox_iframe to mcp_apps_inner_iframe

Pre-launch Checklist

• I signed the CLA.
• I read the Contributors Guide.
• I read the Style Guide.
• I have added updates to the CHANGELOG.
• I updated/added relevant documentation.
• My code changes (if any) have tests.

If you need help, consider asking for advice on the discussion board.

[gemini-code-assist]

Code Review

This pull request renames the sandbox_iframe directory and all associated file paths and references to mcp_apps_inner_iframe across the Angular and Lit client applications. The changes include updates to .gitignore, package.json build scripts, URL construction in mcp-app.ts, shared constants in shared-constants.ts, and an alias in vite.config.ts. Feedback suggests improving URL construction in mcp-app.ts for robustness and readability, addressing naming inconsistencies by fully refactoring constants and filenames to align with the new directory name, and making the node_modules path in vite.config.ts more robust by avoiding hardcoding.

[gemini-code-assist]

To make the URL construction more robust and readable, you could use the URL and URLSearchParams APIs. This avoids manual string concatenation for query parameters and handles encoding correctly.

    const url = new URL(`${currentOrigin}/mcp_apps_inner_iframe/sandbox.html`);
    if (disableSecuritySelfTest) {
      url.searchParams.set('disable_security_self_test', 'true');
    }
    const sandboxUrl = url.toString();

[gemini-code-assist]

While the directory has been renamed to mcp_apps_inner_iframe, these constants and the files they point to (sandbox.ts, sandbox.html) still use the SANDBOX name. This creates some inconsistency. For a more complete refactoring, consider renaming the files and these constants to align with the new directory name. For example, SANDBOX_BASE_PATH could become MCP_APPS_INNER_IFRAME_BASE_PATH. This would improve clarity and consistency across the codebase. Note that this would require updating all usages of these constants and filenames.

[gemini-code-assist]

This hardcoded relative path to node_modules can be brittle. If dependencies are hoisted to a root node_modules directory (common in monorepos) or the project structure changes, this path will break. A more robust approach would be to use a resolution algorithm to find the package path programmatically. For example, you could use a library like resolve for this purpose.