Document reasoning for omitting ctx.EndInvocation()

[MRuhan17]

Added detailed comments explaining the intentional omission of ctx.EndInvocation() and its implications for cross-language consistency.

[gemini-code-assist]

Summary of Changes

Hello @MRuhan17, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances code clarity and maintainability by providing comprehensive documentation for a specific design decision in the agent.go file. It explains the intentional omission of a particular function call, ensuring that the reasoning behind this choice, including its implications for cross-language consistency, is well-understood by current and future developers.

Highlights

• Documenting ctx.EndInvocation() omission: Detailed comments have been added to agent/agent.go explaining why ctx.EndInvocation() is intentionally not called within the runAfterAgentCallbacks function. This addresses a previous TODO comment.
• Rationale for omission: The documentation clarifies that ctx.EndInvocation() is omitted because after-agent callbacks do not check ctx.Ended(), it ensures cross-language consistency by matching the Python ADK's behavior, and the invocation end flag is local and not used later, preventing misleading future contributors.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a comment to explain the intentional omission of ctx.EndInvocation() in runAfterAgentCallbacks. The added context is valuable for future developers. I have one suggestion to refine the comment's formatting and wording for better clarity and adherence to Go's idiomatic style.

[baptmont]

/gemini review

[gemini-code-assist]

Code Review

This pull request adds a comment to explain why ctx.EndInvocation() is not called in runAfterAgentCallbacks. The explanation is helpful for future maintainability. I've suggested a small change to the comment to make it more concise, precise, and to follow standard Go formatting conventions.

[baptmont]

Hi, can you fix the indentation and remove the TODO?