Refactor IncludeContents in State to use internal type.

[sheing-google]

Defines a new IncludeContents type and constants in internal/llminternal and updates the State struct to use it. This improves type safety and addresses a TODO comment.

Internal Refs:

• Defined IncludeContents type and constants in internal/llminternal/agent.go.
• Updated State.IncludeContents field type.
• Updated llmagent.New to cast config value to internal type.
• Updated contents_processor.go to use internal constant.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @sheing-google, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of the IncludeContents setting within the llmagent's internal state. By introducing a dedicated IncludeContents type and constants, it significantly enhances type safety and code clarity, moving away from string-based comparisons. This change directly resolves a standing technical debt item, making the codebase more robust and easier to maintain.

Highlights

• New Type Definition: A new IncludeContents type and associated constants (IncludeContentsNone, IncludeContentsDefault) have been defined in internal/llminternal/agent.go to represent conversation history inclusion settings.
• Type Safety Enhancement: The State.IncludeContents field in internal/llminternal/agent.go has been updated from a generic string to the newly defined IncludeContents type, improving type safety.
• Configuration Update: The llmagent.New function in agent/llmagent/llmagent.go now explicitly casts the IncludeContents configuration value to the new internal type.
• Constant Usage: The contents_processor.go file has been updated to use the IncludeContentsNone constant instead of a magic string literal for comparison, enhancing readability and maintainability.
• TODO Resolution: This change addresses a previous TODO comment regarding the need for an internal type for IncludeContents.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good refactoring that improves type safety by introducing an IncludeContents type and replacing the use of a magic string with a constant. The changes are logical and correctly applied. I have one suggestion to further improve maintainability by removing code duplication that this change introduces.

[sheing-google]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the IncludeContents field to use a dedicated internal type instead of a raw string, which is a great improvement for type safety and code clarity. The changes are well-executed and align with the PR's goal. I have one suggestion to remove a redundant type conversion to make the code even cleaner. Overall, this is a solid refactoring.

[baptmont]

Hi @sheing-google ,

Thanks so much for your contribution! We really appreciate you taking the time.
Before we can merge this pull request, we need you to sign Google's Contributor License Agreement (CLA). You can do this at: https://cla.developers.google.com/
It's a one-time process and covers all Google open source projects.
Please let me know if you have any questions!

[sheing-google]

mhmmm, i already signed the CLA