Skip to content
Closed
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
cb92b70
fix: propagate finish_reason from LiteLLM responses
aperepel Oct 8, 2025
5c43ac2
refactor: address code review feedback
aperepel Oct 8, 2025
ac27a3a
Update src/google/adk/models/lite_llm.py
aperepel Oct 8, 2025
3924bcb
Update src/google/adk/telemetry/tracing.py
aperepel Oct 8, 2025
ab6f577
fix: update finish_reason type hint to support both enum and string
aperepel Oct 8, 2025
7996112
feat: map LiteLLM finish_reason strings to FinishReason enum
aperepel Oct 15, 2025
a1c0938
feat: map LiteLLM finish_reason strings to FinishReason enum
aperepel Oct 15, 2025
692af95
refactor: address bot review suggestions
aperepel Oct 15, 2025
538a5b0
refactor: use _FINISH_REASON_MAPPING directly in tests
aperepel Oct 15, 2025
cb44fb4
refactor: remove unused Union import from llm_response.py
aperepel Oct 15, 2025
0becccf
Apply suggestion from @gemini-code-assist[bot]
aperepel Oct 15, 2025
63d8b71
fix: apply review suggestions for litellm finish_reason
lizzij Oct 28, 2025
76a8f24
Add e2e test for litellm finish reason
lizzij Oct 28, 2025
c736928
fix python formatting
lizzij Oct 28, 2025
ce025f4
Merge branch 'main' into fix/litellm-finish-reason-3109
lizzij Oct 28, 2025
8e6da69
Merge branch 'main' into fix/litellm-finish-reason-3109
xuanyang15 Oct 28, 2025
9622dee
add license
lizzij Oct 28, 2025
b8b49fb
fix sample reasoning agent
lizzij Oct 28, 2025
bb12952
fix python format
lizzij Oct 28, 2025
7171a09
remove agent
lizzij Oct 28, 2025
90466f6
Merge branch 'main' into fix/litellm-finish-reason-3109
lizzij Oct 29, 2025
fe9dbcc
Merge branch 'main' into fix/litellm-finish-reason-3109
lizzij Oct 29, 2025
da6ed0a
Merge branch 'main' into fix/litellm-finish-reason-3109
lizzij Oct 29, 2025
840b126
Merge branch 'main' into fix/litellm-finish-reason-3109
lizzij Oct 29, 2025
5dbc5a7
Merge branch 'main' into fix/litellm-finish-reason-3109
lizzij Oct 30, 2025
b159d59
Merge branch 'main' into fix/litellm-finish-reason-3109
lizzij Oct 30, 2025
02adaa2
Merge branch 'main' into fix/litellm-finish-reason-3109
lizzij Oct 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/google/adk/models/llm_response.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,11 @@ class LlmResponse(BaseModel):
"""

finish_reason: Optional[types.FinishReason] = None
"""The finish reason of the response."""
"""The finish reason of the response.

Always a types.FinishReason enum. String values from underlying model providers
are mapped to corresponding enum values (with fallback to OTHER for unknown values).
"""

error_code: Optional[str] = None
"""Error code if the response is an error. Code varies by model."""
Expand Down