-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feature/auto-create-new-session #4072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lwangverizon
wants to merge
12
commits into
google:main
Choose a base branch
from
lwangverizon:feature/auto-create-new-session
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+195
−23
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8b6af5d
move session creation to runner level
lwangverizon ce2c649
removed old test case
lwangverizon 5742ec5
Merge branch 'main' into feature/auto-create-new-session
lwangverizon 058922c
update to all references
lwangverizon 63f883c
Merge remote-tracking branch 'origin/feature/auto-create-new-session'…
lwangverizon 5f465c1
update pyink
lwangverizon 571bee5
added test case
lwangverizon 63e4a0d
Merge branch 'main' into feature/auto-create-new-session
lwangverizon ef90f12
add auto_create_session flag and default to false
lwangverizon 7df6afc
keep run_debug intact
lwangverizon 2fef4bc
update session not found message
lwangverizon 57db5f1
added helper function and test cases
lwangverizon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preference to include tests for
rewind_asyncandrun_liveas well. Thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requested changes have been addressed. Please note that I decided to keep the auto_create_session flag outside of the helper function to ensure better code readability. New test cases have also been included. I appreciate your review.