Skip to content

Fix unintended user message text that triggers content filters (Closes #4249) #4315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KrshnKush wants to merge 5 commits into from
Closed

Fix unintended user message text that triggers content filters (Closes #4249) #4315

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47a1024
Update request handling text for clarity
KrshnKush Jan 29, 2026
c1eea2d
Update test assertion message content
KrshnKush Jan 29, 2026
ef7e376
Update comments for finish reason mapping
KrshnKush Jan 29, 2026
50e4388
Replace hardcoded text with fallback variable
KrshnKush Jan 29, 2026
0a24a15
Update test to use fallback user content text
KrshnKush Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/google/adk/models/lite_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@
# 1. FinishReason.TOOL_CALL enum does not exist (as of google-genai 0.8.0)
# 2. Tool calls represent normal completion (model stopped to invoke tools)
# 3. Gemini native responses use STOP for tool calls (see lite_llm.py:910)
# 4. Mapping tool-related finish reasons to STOP preserves backward
# compatibility with existing ADK consumers that assume STOP
# indicates a successful, non-error completion.
_FINISH_REASON_MAPPING = {
"length": types.FinishReason.MAX_TOKENS,
"stop": types.FinishReason.STOP,
Expand Down Expand Up @@ -490,7 +493,7 @@ def _append_fallback_user_content_if_missing(
content.parts = []
content.parts.append(
types.Part.from_text(
text="Handle the requests as specified in the System Instruction."
text="Handle the incoming request according to the provided requirements."
)
)
return
Expand All @@ -500,8 +503,7 @@ def _append_fallback_user_content_if_missing(
parts=[
types.Part.from_text(
text=(
"Handle the requests as specified in the System"
" Instruction."
"Handle the incoming request according to the provided requirements."
)
),
],
Expand Down
4 changes: 2 additions & 2 deletions tests/unittests/models/test_litellm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,14 +979,14 @@ async def test_generate_content_async_adds_fallback_user_message(
]
assert any(
message.get("content")
== "Handle the requests as specified in the System Instruction."
== "Handle the incoming request according to the provided requirements."
for message in user_messages
)
assert (
sum(1 for content in llm_request.contents if content.role == "user") == 1
)
assert llm_request.contents[-1].parts[0].text == (
"Handle the requests as specified in the System Instruction."
"Handle the incoming request according to the provided requirements."
)


Expand Down