Skip to content

feat: expose live_session_resumption_update in events for cross-connection resumption #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AshleyMaloney wants to merge 3 commits into
base: main
Choose a base branch
from
+133 −8
Open

feat: expose live_session_resumption_update in events for cross-connection resumption #4358

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f77fbb
feat: expose live_session_resumption_update in events for cross-conne…
AshleyMaloney Feb 2, 2026
3cb4a66
refactor: consolidate live_session_resumption_update handling in _pos…
AshleyMaloney Feb 2, 2026
ecfc3a1
test: add unit tests for _postprocess_live session resumption
AshleyMaloney Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions src/google/adk/flows/llm_flows/base_llm_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,14 +369,6 @@ def get_author_for_event(llm_response):
while True:
async with Aclosing(llm_connection.receive()) as agen:
async for llm_response in agen:
if llm_response.live_session_resumption_update:
logger.info(
'Update session resumption handle:'
f' {llm_response.live_session_resumption_update}.'
)
invocation_context.live_session_resumption_handle = (
llm_response.live_session_resumption_update.new_handle
)
model_response_event = Event(
id=Event.new_id(),
invocation_id=invocation_context.invocation_id,
Expand Down Expand Up @@ -739,6 +731,25 @@ async def _postprocess_live(
async for event in agen:
yield event

# Handle session resumption updates for cross-connection resumption.
# Must be before skip condition - resumption updates have no content.
if llm_response.live_session_resumption_update:
# Update internal handle for auto-resumption within run_live()
logger.info(
'Update session resumption handle: %s',
llm_response.live_session_resumption_update,
)
invocation_context.live_session_resumption_handle = (
llm_response.live_session_resumption_update.new_handle
)

# Expose update in event for application-level cross-connection resumption
model_response_event.live_session_resumption_update = (
llm_response.live_session_resumption_update
)
yield model_response_event
return
Comment on lines +736 to +751
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This new logic is a great addition for enabling cross-connection session resumption. To ensure this feature remains robust and to prevent future regressions, it would be beneficial to add a unit test for this new code path in _postprocess_live. A test could verify that when an llm_response contains a live_session_resumption_update, the invocation_context is updated correctly and the corresponding event is yielded.

Copy link
Collaborator

@ryanaiagent ryanaiagent Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a unit test.


# Skip the model response event if there is no content and no error code.
# This is needed for the code executor to trigger another loop.
# But don't skip control events like turn_complete or transcription events.
Expand Down
Loading