fix: use exchanged OAuth credential in ApplicationIntegrationToolset#4659
fix: use exchanged OAuth credential in ApplicationIntegrationToolset#4659pandego wants to merge 2 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where ApplicationIntegrationToolset was not correctly propagating exchanged OAuth credentials to connector tools. The changes ensure that IntegrationConnectorTool instances receive and use the proper exchanged credentials, including runtime access tokens, thereby fixing authentication for these tools. A new test case has been added to validate this behavior. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @pandego, thank you for creating this PR! It looks like you haven't signed a Contributor License Agreement (CLA) yet. You'll need to sign one before we can look at your pull request. Please visit https://cla.developers.google.com/ to see your current agreements or to sign a new one. |
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where exchanged OAuth credentials were not being propagated to IntegrationConnectorTool instances. The change updates ApplicationIntegrationToolset.get_tools() to correctly use the exchanged_auth_credential. A regression test is also added to cover this case.
My review focuses on improving the implementation to avoid side effects. I've suggested a change to prevent in-place modification of tool instances within the toolset, which improves predictability and aligns with best practices for getter methods.
Summary
ApplicationIntegrationToolset.get_tools()to propagateAuthConfig.exchanged_auth_credentialto generatedIntegrationConnectorToolinstancesFixes #4553
Testing plan
uv run --extra test pytest -q tests/unittests/tools/application_integration_tool/test_application_integration_toolset.py tests/unittests/tools/application_integration_tool/test_integration_connector_tool.pyNotes