Skip to content

fix: use exchanged OAuth credential in ApplicationIntegrationToolset#4659

Open
pandego wants to merge 2 commits intogoogle:mainfrom
pandego:fix/4553-ait-exchanged-auth-credential
Open

fix: use exchanged OAuth credential in ApplicationIntegrationToolset#4659
pandego wants to merge 2 commits intogoogle:mainfrom
pandego:fix/4553-ait-exchanged-auth-credential

Conversation

@pandego
Copy link

@pandego pandego commented Feb 28, 2026

Summary

  • update ApplicationIntegrationToolset.get_tools() to propagate AuthConfig.exchanged_auth_credential to generated IntegrationConnectorTool instances
  • ensure connector tools use exchanged OAuth credentials (including runtime access token) instead of only the raw auth credential
  • add regression coverage for exchanged credential propagation

Fixes #4553

Testing plan

  • uv run --extra test pytest -q tests/unittests/tools/application_integration_tool/test_application_integration_toolset.py tests/unittests/tools/application_integration_tool/test_integration_connector_tool.py

Notes

  • This is a minimal fix scoped to connector-tool credential wiring only.

@google-cla
Copy link

google-cla bot commented Feb 28, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where ApplicationIntegrationToolset was not correctly propagating exchanged OAuth credentials to connector tools. The changes ensure that IntegrationConnectorTool instances receive and use the proper exchanged credentials, including runtime access tokens, thereby fixing authentication for these tools. A new test case has been added to validate this behavior.

Highlights

  • Credential Propagation: Updated ApplicationIntegrationToolset to propagate exchanged OAuth credentials to generated IntegrationConnectorTool instances.
  • Connector Tool Authentication: Ensured connector tools utilize the exchanged OAuth credential, including the runtime access token, instead of only the raw authentication credential.
  • Regression Coverage: Added a new test case to provide regression coverage for the propagation of exchanged credentials.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/google/adk/tools/application_integration_tool/application_integration_toolset.py
    • Modified the get_tools method to check for and apply exchanged_auth_credential to IntegrationConnectorTool instances before returning the list of tools.
  • tests/unittests/tools/application_integration_tool/test_application_integration_toolset.py
    • Added test_get_tools_uses_exchanged_auth_credential_when_available to verify that ApplicationIntegrationToolset correctly assigns the exchanged_auth_credential to tools when available.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the tools [Component] This issue is related to tools label Feb 28, 2026
@adk-bot
Copy link
Collaborator

adk-bot commented Feb 28, 2026

Response from ADK Triaging Agent

Hello @pandego, thank you for creating this PR!

It looks like you haven't signed a Contributor License Agreement (CLA) yet. You'll need to sign one before we can look at your pull request.

Please visit https://cla.developers.google.com/ to see your current agreements or to sign a new one.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where exchanged OAuth credentials were not being propagated to IntegrationConnectorTool instances. The change updates ApplicationIntegrationToolset.get_tools() to correctly use the exchanged_auth_credential. A regression test is also added to cover this case.

My review focuses on improving the implementation to avoid side effects. I've suggested a change to prevent in-place modification of tool instances within the toolset, which improves predictability and aligns with best practices for getter methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools [Component] This issue is related to tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ApplicationIntegrationToolset not picking up Gemini Enterprise Authorization

2 participants