Skip to content

Fix OAuth redirect URI to follow base href #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarmadalikhanofficial wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix OAuth redirect URI to follow base href #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/utils/url-util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,18 @@ import {env} from '../env/env';

export class URLUtil {
/**
* Get the base URL without any path
* @returns {string} Base URL (protocol + hostname + port)
* Get the app base URL as defined by the document <base> tag (or origin).
* This avoids hard coded paths so OAuth redirect URIs always match the
* actual deployment location.
*/
static getBaseUrlWithoutPath(): string {
// Use the URL constructor for robust URL parsing
const currentUrl = window.location.href;
const urlObject = new URL(currentUrl);
const baseElement = document.querySelector('base');
if (baseElement?.href) {
return baseElement.href;
}

// Construct base URL using origin property
// Origin includes protocol, hostname, and port
return urlObject.origin + '/dev-ui/';
const urlObject = new URL(window.location.href);
return `${urlObject.origin}/`;
}

/**
Expand Down