Skip to content

Add use_cvdalloc=true to the defaults file. #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
3405691582 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add use_cvdalloc=true to the defaults file. #1972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions base/debian/cf_defaults
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
use_cvdalloc=true
Copy link
Member

@Databean Databean Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case this ends up with unexpected breakage, would it be safer to first make sure cuttlefish-defaults is installed everywhere it should be before it starts introducing behavioral changes?

If cuttlefish-defaults doesn't intentionally introduce a behavioral change, it is less likely to be rolled back, and then the behavioral change of enabling cvdalloc by default would have a smaller rollback than "uninstall the package."

Copy link
Collaborator Author

@3405691582 3405691582 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessarily safer, but it's probably better all the same. I thought the change making cuttlefish-defaults a dependency of cuttlefish-common made it out to a release already, but it turns out it hadn't. I think this change in particular can sit on ice for a bit more.

Loading