Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject directives #1033

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Inject directives #1033

wants to merge 2 commits into from

Conversation

adetaylor
Copy link
Collaborator

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@adetaylor
Modularize directive handling.
73d3edc 
No intentional functional changes.

This fixes two immediate bugs:
* The list of possible directives listed within error messages was incorrect
  ("expected generate, generate_pod," etc.)
* We were failing to output all directives within reproduction cases.

This forces symmetrical handling for all directives so prevents these sorts of
bugs being introduced in future.
@adetaylor
Failed attempt to allow directive injection.
b8bd700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adetaylor