Add Bazel integration #1255
Add Bazel integration #1255
Conversation
|
Though I opened this PR I know I used some "hacky" way in |
BUILD
Outdated
| "//third-party:proc-macro2", | ||
| "//third-party:quote", | ||
| "//third-party:serde", | ||
| "//third-party:thiserror", |
There was a problem hiding this comment.
Thanks for this PR.
However, I hadn't realized that bazel support would require hard-coding all these dependencies. That's not OK with me - the Cargo.toml files need to be the sole source of truth - can you instead add a script or tool to generate these BUILD files based on the Cargo.toml?
More generally, I'm concerned that the project structure is not static enough to maintain a duplicate set of build instructions. It feels like it would be appropriate to check in such BUILD files (or equivalent) only when/if autocxx reaches 1.0 and we're therefore relatively confident that big structural changes will be unusual. I don't think we're at that point yet.
There was a problem hiding this comment.
Thank you for the review. Yes, it was possible to drop the hard-coding deps in BUILD by all_crate_deps. I missed this utility.
WORKSPACE
Outdated
| rules_rust_dependencies() | ||
|
|
||
| rust_register_toolchains( | ||
| versions = ["1.66.0"], |
There was a problem hiding this comment.
Is this dependent on the CI environment?
There was a problem hiding this comment.
Ah, it is not necessary. It should be alright for stable and nigthly which will be registered as per http://bazelbuild.github.io/rules_rust/.
third-party/Cargo.toml
Outdated
| @@ -0,0 +1,42 @@ | |||
| [workspace] | |||
| [package] | |||
| name = "third-party" | |||
There was a problem hiding this comment.
These are generated files, right? Please check in the tool/procedure to generate them, instead of these files.
There was a problem hiding this comment.
Thank you. I could drop these files. Now the generated files are only under third-party/bazel/* generated by bazel run //third-party:vendor.
There was a problem hiding this comment.
Sorry for the lack of comment here - I've been travelling a bit lately.
I'm still not OK with these being checked in. I want to be able to upgrade dependencies by changing only Cargo.toml files - then everything else needs to be autogenerated.
nak3
force-pushed
the
bzael-test-third2
branch
from
6962287
to
e0ffc93
Compare
This reverts commit 1d9cadc.
Fixes #478
This patch adds Bazel Integration.
It can build:
autocxx-*libs/binaries - please seeBUILDin the top directory.demo- please seedemo/BUILD.,which follows the structure of cxx project. So CI also built the demo app.
The commits contain a tons of file change but most of them are autogen files.
The autogen and non-autogen files are separated so please refer to the commit message.