Skip to content

Commit

Permalink
Windows packaging: Use new JSON config files and per-user setup
Browse files Browse the repository at this point in the history
- Update build script
- Package Binary Ninja exporter
- Move plugins folders in BinDiff installation to paths with friendlier
  names
- Skip registry search for IDA Pro due to different installation method
- Remove IDA Pro directory dialog
- Use `bindiff_config_setup` to update config file during installation,
  use `--per_user` to perform per-user setup

Other changes:
- Simplify check in `LaunchConditions` to use Wix' built-in `MajorUpgrade`
  instead of custom implementation
- Change ownership of `%ProgramData%\BinDiff` to "Administrators" group (from
  "LocalSystem")
- Update output file in Wix project to `bindiff7.msi`
- Update BinExport's build script to build the Binary Ninja exporter on Windows

PiperOrigin-RevId: 344986195
Change-Id: I1126541b42d76bc7dda1b133831b3d2b90c598fa
  • Loading branch information
cblichmann authored and copybara-github committed Dec 1, 2020
1 parent b886b8f commit ac9328c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
Empty file modified binaryninja/main_plugin.cc
100644 → 100755
Empty file.
5 changes: 5 additions & 0 deletions binaryninja/main_plugin.h
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
#include "binaryninjaapi.h" // NOLINT
// clang-format on

#ifdef _WIN32
// binaryninja.h includes Windows.h, so undefine
#undef ERROR
#endif

namespace security::binexport {

class Plugin {
Expand Down

0 comments on commit ac9328c

Please sign in to comment.