This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
Improve SourceCodeLocation accuracy. #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CssDeclarationNode did not have the SourceCodeLocation as a constructor parameter, nor did it preserve it on a deep copy. CssNodesListNode now tries to build its locations from its constituent nodes unless a SourceCodeLocation is set explicitly. Several bugs in the actual parser are also fixed as are numerous problems in FixupFontDeclarations. There are new tests and a SourceCodeLocationSubject for Truth which should make new tests easier to write.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CssDeclarationNode did not have the SourceCodeLocation as a constructor
parameter, nor did it preserve it on a deep copy.
CssNodesListNode now tries to build its locations from its constituent nodes
unless a SourceCodeLocation is set explicitly.
Several bugs in the actual parser are also fixed as are numerous problems in
FixupFontDeclarations.
There are new tests and a SourceCodeLocationSubject for Truth which should
make new tests easier to write.