Flip the default for explicitBindingConflictsWithInject to enabled. #4183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RELNOTES=Flip the default for explicitBindingConflictsWithInject to error PiperOrigin-RevId: 297153765
ergutierz
reviewed
Dec 15, 2023
| * constructor used in an ancestor component. | ||
| */ | ||
| EXPLICIT_BINDING_CONFLICTS_WITH_INJECT(WARNING, ERROR, NONE), | ||
| EXPLICIT_BINDING_CONFLICTS_WITH_INJECT(ERROR, WARNING, NONE), |
There was a problem hiding this comment.
The order changes the default value -- the first value passed to the enum's constructor is the default value.
|
[like] Erik Gutierrez reacted to your message:
________________________________
From: Brad Corso ***@***.***>
Sent: Friday, December 15, 2023 10:19:54 PM
To: google/dagger ***@***.***>
Cc: Erik Gutierrez ***@***.***>; Comment ***@***.***>
Subject: Re: [google/dagger] Flip the default for explicitBindingConflictsWithInject to enabled. (PR #4183)
@bcorso commented on this pull request.
________________________________
In java/dagger/internal/codegen/compileroption/ProcessingEnvironmentCompilerOptions.java<#4183 (comment)>:
@@ -404,7 +404,7 @@ public ImmutableList<String> aliases() {
* How to report that an explicit binding in a subcomponent conflicts with an ***@***.*** @Inject}
* constructor used in an ancestor component.
*/
- EXPLICIT_BINDING_CONFLICTS_WITH_INJECT(WARNING, ERROR, NONE),
+ EXPLICIT_BINDING_CONFLICTS_WITH_INJECT(ERROR, WARNING, NONE),
The order changes the default value -- the first value passed to the enum's constructor is the default value.
—
Reply to this email directly, view it on GitHub<#4183 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5FBRL5QQSOH4TOWTU4J4BDYJTEIVAVCNFSM6AAAAABALXBFOGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBVGAYTCMRZGM>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flip the default for explicitBindingConflictsWithInject to enabled.
RELNOTES=Flip the default for explicitBindingConflictsWithInject to error