Add support for printing DTS out of FDT #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4tx
force-pushed
the
fdt-print-dts
branch
2 times, most recently
from
bac4c2c to
204e7ab
Compare
qwandor
reviewed
Dec 9, 2025
tests/fdt.rs
Outdated
|
|
||
| #[test] | ||
| fn pretty_print() { | ||
| let dtb = include_bytes!("dtb/test_pretty_print.dtb"); |
Collaborator
There was a problem hiding this comment.
How about having this test all the DTB/DTS pairs you have in the test directory?
Collaborator
Author
There was a problem hiding this comment.
Fair. I thought there will be more differences between a human-written DTS and the outputted one (as we use heuristics to get decent DTS formatting for the values), but it seems to be just fine, so I've just added this.
qwandor
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.