-
Notifications
You must be signed in to change notification settings - Fork 3.4k
gRPC callbackService support added #8666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dbaileychess @mustiikhalil @aardappel could you guys please review this , if there are any changes required , I'd be happy to make them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good!
08398d8
to
7aa060d
Compare
1f9f63e
to
37c3981
Compare
Signed-off-by: shankeleven <[email protected]>
37c3981
to
c0232ab
Compare
there were some issues wiht the CI buildkite, so had to make some minor changes, nothing substantial |
Some of the CI errors definitely relates to this PR: https://github.com/google/flatbuffers/actions/runs/17030064051/job/48271145482?pr=8666 |
…ervice & async_ reactor APIs); update formatting and method placement
this buildkite check has not been triggered ig |
Added Support for gRPC CallbackService
gRPC supports two flavors of asynchronous callbacks -- from their documentation:
https://grpc.io/docs/languages/cpp/callback/
Checklist